Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search for nvdisasm in the conda environment / CUDA_HOME / default CUDA install location in addition to the path #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Search for nvdisasm in the conda environment / CUDA_HOME / default CUDA install location in addition to the path #13

wants to merge 2 commits into from

Conversation

brycelelbach
Copy link
Contributor

Fixes #9.

I'm not sure how good the unit test coverage is for this, or the other path search functionality. Ideally we'd need contained tests that cover:

  • Conda
  • A default CUDA install (e.g. /usr/local/cuda):
    • With the full toolkit.
    • With only libraries, no nvdisasm etc.
    • With only libraries, but nvdisasm in PATH.
  • CUDA_HOME:
    • With the full toolkit.
    • With only libraries, no nvdisasm etc.
    • With only libraries, but nvdisasm in PATH.

@brycelelbach
Search for nvdisasm in the conda environment / CUDA_HOME / default …
7abcd36 
…CUDA install

location in addition to the path. Fixes NVIDIA#9.
@gmarkall gmarkall added the 3 - Ready for Review Ready for review by team label Jul 15, 2024
@gmarkall gmarkall changed the base branch from main to develop August 1, 2024 14:35
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 1, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@gmarkall
Copy link
Collaborator

gmarkall commented Aug 1, 2024

Just merged develop and pushed so that CI can run on this PR.

@gmarkall
Copy link
Collaborator

gmarkall commented Aug 1, 2024

/ok to test

@gmarkall
Copy link
Collaborator

gmarkall commented Aug 6, 2024

Looks like there's some issue with nvdisasm tests with this PR - I haven't looked into it yet, but let me know if any guidance would be helpful.

@gmarkall gmarkall added 4 - Waiting on author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels Aug 6, 2024
@gmarkall gmarkall changed the base branch from develop to main October 21, 2024 14:48
@gmarkall
Copy link
Collaborator

Rebased on main - I'm trying to get everything away from develop now as it no longer seems necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4 - Waiting on author Waiting for author to respond to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] SASS disassembly always tries to use nvdisasm on the PATH
2 participants
@brycelelbach @gmarkall